Env: add initial object cache support #55909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.7 MB ℹ️ View Unchanged
|
Allows to run them even when Docker is not installed
|
Flaky tests detected in 5c0c146. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6785596724
|
swissspidy
changed the title
swissspidy
commented
Nov 7, 2023
Comment on lines
+12
to
+17
| jest.mock( 'child_process', () => { | ||
| return { | ||
| exec: jest.fn( Promise.resolve.bind( Promise ) ), | ||
| execSync: jest.fn( () => 'Success!' ), | ||
| }; | ||
| } ); |
There was a problem hiding this comment.
This way tests can run even if Docker is not installed.
swissspidy
commented
Nov 7, 2023
| @@ -2,6 +2,7 @@ | |||
| "core": "WordPress/WordPress", | |||
| "plugins": [ "." ], | |||
| "themes": [ "./test/emptytheme" ], | |||
| "objectCache": "memcached", | |||
There was a problem hiding this comment.
Just for dogfooding, to remove before merge
swissspidy
requested review from
noahtallen,
ObliviousHarmony and
t-hamano
as code owners
|
To be honest, I'm not convinced that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds initial object cache support to
@wordpress/envpackage throughmemcached. No other object cache is supported at this point, though support could be added in the future.Fixes #55853
To-do
object-cacheservice when checking out trunk. Maybe simply need to restart the env?Why?
Many large sites use a persistent external object cache. In order to test code with such a setup, it's important that wp-env supports an object cache as well. Especially useful for performance tests as well, to test code with and without object cache.
How?
A new
objectCacheenum config field can be used to select the type of object cache to setup. Currently supported values:null/undefined(default) - no object cachememcached- uses memcache_d_If object cache is enabled, then:
object-cacheandtests-object-cacheservices todocker-compose.ymlobject-cache.phpdrop-in towp-content/Testing Instructions
Enable object cache support through
.wp-env.jsonor.wp-env.override.jsonlike so:{ "objectCache": "memcached" }After that, run
wp-env start --updateTesting is needed especially with different PHP versions.
Testing Instructions for Keyboard
Screenshots or screencast